Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icu: 59 -> 64 #60250

Merged
merged 2 commits into from
May 27, 2019
Merged

icu: 59 -> 64 #60250

merged 2 commits into from
May 27, 2019

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

https://github.com/unicode-org/icu/releases/tag/release-64-2

They say updates can go smoothly so let's try! (http://userguide.icu-project.org/icufaq)

We should probably get rid of the old versions that are not needed anymore if everything builds after this. It doesn't look like they have any LTS versions - they're just releasing new versions.

Obsoletes or resolves: #39388 and #52632

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ 10.rebuild-darwin: 501-1000 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 labels Apr 26, 2019
@FRidh
Copy link
Member

FRidh commented May 4, 2019

Could you rebase? It appears there are some incorrect commits.

@ofborg ofborg bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 4, 2019
@JohnAZoidberg
Copy link
Member Author

@GrahamcOfBorg build icu

@JohnAZoidberg JohnAZoidberg changed the title Icu64 icu: 59 -> 64 May 25, 2019
@infinisil infinisil merged commit dd12269 into NixOS:staging May 27, 2019
@JohnAZoidberg JohnAZoidberg deleted the icu64 branch May 27, 2019 19:43
vcunat added a commit that referenced this pull request Jun 5, 2019
@vcunat
sword: fixup build with icu >= 61
0d29488 
/cc #60250 (2fe63c8).
vcunat added a commit that referenced this pull request Jun 5, 2019
@vcunat
treewide icu61+ fixes
290695d 
It's exactly the same issue as in the parent commit.
/cc #60250 (2fe63c8).
@vcunat
Copy link
Member

vcunat commented Jun 5, 2019

I managed to fix a few regressions quickly. PyICU is the only remaining problem I know about; there the compile flags isn't respected I suspect.

@vcunat
Copy link
Member

vcunat commented Jun 6, 2019

Hopefully fine now: 326148ec9

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/29

This was referenced Jul 12, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JohnAZoidberg @FRidh @vcunat @nixos-discourse @infinisil